Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RichTextPropertyPane text-indent bug #454

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

SharePickle
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues?

What's in this Pull Request?

Fixed RichTextPropertyPane text-indent bug.

Text indent buttons were copy-pasta of subscript and superscript buttons. Clicking on the text-indent buttons would call subscript or superscript instead.

@msftclas
Copy link

msftclas commented Jan 9, 2020

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

Codecov Report

Merging #454 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #454   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf8856...4bcbb32. Read the comment docs.

@SharePickle
Copy link
Contributor Author

Oops, looks like I included some unnecessary formatting, sorry about that.
How do I avoid that?

@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Jan 10, 2020
@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jan 10, 2020
@AJIXuMuK AJIXuMuK merged commit fa61486 into pnp:dev Jan 10, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @SharePickle,

Thanks for the fix! It will be included in next version, but you can already test it in beta version.

Oops, looks like I included some unnecessary formatting, sorry about that.
How do I avoid that?

Some components in this repo were created when VS Code had default indent of 4 spaces. Now the default is 2 spaces. Most probably you applied formatting to the whole file that led to changed indents.

Anyways, I merged the PR :)

@estruyf estruyf mentioned this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants