Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#412 Add missing localization files. #413

Merged
merged 1 commit into from
Nov 13, 2019
Merged

#412 Add missing localization files. #413

merged 1 commit into from
Nov 13, 2019

Conversation

siata13
Copy link
Contributor

@siata13 siata13 commented Nov 12, 2019

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? #412

What's in this Pull Request?

Added new localization files to avoid control (FilePicker) to throw an exception. The files are copies of the English (en-us.ts) file and could be updated in the future.
Add missing FilePicker localization keys to the existing languages.

List of added language files:

  • Bulgarian (Bulgaria)
  • Catalan (Catalan)
  • Danish (Denmark)
  • Greek (Greece)
  • Spanish (Spain)
  • Estonian (Estonia)
  • Basque (Basque)
  • Finnish (Finland)
  • Italian (Italy)
  • Japanese (Japan)
  • Lithuanian (Lithuania)
  • Latvian (Latvia)
  • Norwegian, Bokmål (Norway)
  • Dutch (Netherlands)
  • Polish (Poland)
  • Portuguese (Portugal)
  • Romanian (Romania)
  • Russian (Russia)
  • Slovak (Slovakia)
  • Serbian (Latin, Serbia)
  • Swedish (Sweden)
  • Turkish (Turkey)
  • Vietnamese (Vietnam)
  • Chinese (Simplified, PRC)
  • Chinese (Traditional, Taiwan)

@codecov-io
Copy link

Codecov Report

Merging #413 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #413   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      164           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e382c5e...63acc99. Read the comment docs.

@AJIXuMuK
Copy link
Collaborator

Hi @siata13

I thought it should fall back to the default locale if the specified localization has not been found....
But anyway, it's still good to have all files ready :)

@AJIXuMuK AJIXuMuK merged commit c21ebe6 into pnp:dev Nov 13, 2019
@siata13
Copy link
Contributor Author

siata13 commented Nov 13, 2019

Hi @AJIXuMuK ,

Apparently there were some missing keys in one of the language file (which caused the exception) I have been tested.
In any case, the new files can be used in the future.

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants