-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilePicker control #366
Merged
FilePicker control #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bugs. Refactor.
Fix bugs.
Fix OneDrive items handle. Add scrollable panel for files pane.
Fix TSLint warnings. Fix bugs.
Remove unused code. Cleanup. Fix TSLint warnings.
Fix bugs. Refactor WebSearch.
Refactor. Fix bugs.
Replace IconButton with Action button. Update documentation.
Codecov Report
@@ Coverage Diff @@
## dev #366 +/- ##
==========================================
- Coverage 73.31% 73.18% -0.14%
==========================================
Files 18 18
Lines 802 798 -4
Branches 154 164 +10
==========================================
- Hits 588 584 -4
Misses 164 164
Partials 50 50
Continue to review full report at Codecov.
|
Thanks @siata13 this is an amazing new control which adds a lot of value!!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
PR contains a new control FilePicker that allows to select a file from various places.