Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: option to render Time part either as Masked Text or a… #349

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

AJIXuMuK
Copy link
Collaborator

…s Dropdown

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? #330

What's in this Pull Request?

2 new properties has been added to DateTimePicker:

  1. timeDisplayControlType - Specifies what type of control to use when rendering time part. Text or Dropdown. Default - Text
  2. showLabels - Specifies if labels in front of date and time parts should be rendered. Default - true

@codecov-io
Copy link

Codecov Report

Merging #349 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #349   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines         767      767           
  Branches      149      149           
=======================================
  Hits          559      559           
  Misses        161      161           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb2e99...15ae828. Read the comment docs.

@estruyf estruyf merged commit 15ae828 into pnp:dev Sep 10, 2019
@estruyf
Copy link
Member

estruyf commented Sep 10, 2019

@AJIXuMuK thank you very much for this one!

@estruyf estruyf added this to the 1.15.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants