Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClick and onDblClick should return void, not {} #321

Merged
merged 1 commit into from
Jul 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface IFieldLookupRendererProps extends IFieldRendererProps {
/**
* custom event handler of lookup item click. If not set the dialog with Display Form will be shown
*/
onClick?: (args: IFieldLookupClickEventArgs) => {};
onClick?: (args: IFieldLookupClickEventArgs) => void;
/**
* Field's id.
*/
Expand Down
6 changes: 3 additions & 3 deletions src/controls/fields/fieldNameRenderer/FieldNameRenderer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@ export interface IFieldNameRendererProps extends IFieldRendererProps {
isNew?: boolean;
/**
* true if the document type has preview (true by default).
* The flag impacts on the link's href:
* The flag impacts on the link's href:
* if the flag is tru then the href is constructed like #id=${filePath}&parent=${filePath.substring(0, filePath.lastIndexOf('/'))},
* otherwise the href will contain filePath only.
*/
hasPreview?: boolean;
/**
* custom handler for link click. If not set link click will lead to rendering document preview
*/
onClick?: (args: IFieldNameClickEventArgs) => {};
onClick?: (args: IFieldNameClickEventArgs) => void;
/**
* custom handler for link double click. If not set link will use OOTB behavior.
*/
onDoubleClick?: (args: IFieldNameClickEventArgs) => {};
onDoubleClick?: (args: IFieldNameClickEventArgs) => void;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface IFieldTitleRendererProps extends IFieldRendererProps {
/**
* custom title click event handler. If not set Display form for the item will be displaed
*/
onClick?: (args: IFieldTitleClickEventArgs) => {};
onClick?: (args: IFieldTitleClickEventArgs) => void;
}

/**
Expand Down