Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #279 #280

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Fixed #279 #280

merged 1 commit into from
Apr 25, 2019

Conversation

hugoabernier
Copy link
Contributor

@hugoabernier hugoabernier commented Apr 25, 2019

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #279

What's in this Pull Request?

Resolves issue where other dropdowns on the page take the colour of the RichText dropdown.

Also fixes minor coding styles as per @estruyf feedback

@codecov-io
Copy link

Codecov Report

Merging #280 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #280   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          17       17           
  Lines         759      759           
  Branches      146      156   +10     
=======================================
  Hits          549      549           
  Misses        163      163           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf0ba6...c212ef9. Read the comment docs.

@estruyf estruyf merged commit b4f7566 into pnp:dev Apr 25, 2019
@estruyf
Copy link
Member

estruyf commented Apr 25, 2019

Thanks @hugoabernier!

@estruyf estruyf added this to the 1.13.1 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants