Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxonomyPicker: term actions #235

Merged
merged 2 commits into from
Feb 12, 2019
Merged

TaxonomyPicker: term actions #235

merged 2 commits into from
Feb 12, 2019

Conversation

siata13
Copy link
Contributor

@siata13 siata13 commented Feb 10, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]

What's in this Pull Request?

Add term actions functionality to the TaxonomyPicker control. Term actions allow to create own actions that will be executed on the concrete term, e.g. get other term labels or ad new term.

@codecov-io
Copy link

Codecov Report

Merging #235 into dev will decrease coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #235      +/-   ##
==========================================
- Coverage   72.71%   69.95%   -2.76%     
==========================================
  Files          16       15       -1     
  Lines         744      689      -55     
  Branches      138      133       -5     
==========================================
- Hits          541      482      -59     
- Misses        159      164       +5     
+ Partials       44       43       -1
Impacted Files Coverage Δ
src/controls/chartControl/PaletteGenerator.ts 26.31% <0%> (-32.23%) ⬇️
src/controls/chartControl/AccessibleChartTable.tsx 76% <0%> (-9.72%) ⬇️
src/controls/chartControl/ChartControl.types.ts 100% <0%> (ø) ⬆️
src/controls/chartControl/index.ts
src/controls/listView/ListView.tsx 56.56% <0%> (+0.31%) ⬆️
src/controls/chartControl/ChartControl.tsx 67.88% <0%> (+4.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b2f12...ebc2d88. Read the comment docs.

@estruyf estruyf merged commit ebc2d88 into pnp:dev Feb 12, 2019
estruyf added a commit that referenced this pull request Feb 12, 2019
@estruyf estruyf added this to the 1.12.0 milestone Feb 12, 2019
@estruyf
Copy link
Member

estruyf commented Feb 12, 2019

Thanks @siata13 I have done some refactoring + documentation changes. This is a helpful enhancement to the control!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants