Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of filter on ListView. (#99) #201

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Add support of filter on ListView. (#99) #201

merged 1 commit into from
Dec 19, 2018

Conversation

siata13
Copy link
Contributor

@siata13 siata13 commented Dec 11, 2018

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? #99

What's in this Pull Request?

The PR adds support for feature requested in issue #99 - PR adds the possibility to execute filtering on ListView control. Update of the documentation of ListView control.

Features/Changes:

  • Add support of execute filtering on ListView control.
  • Provide default filterValue, filter box placeolder, filterbox visibility.
  • Add support for full text filtering.
  • Add support for filter by column name/display name with the syntax <ColumnName>:<FilterValue> - ':' as a separator.

Update documentation.
@msftclas
Copy link

msftclas commented Dec 11, 2018

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

Codecov Report

Merging #201 into dev will decrease coverage by 2.29%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #201     +/-   ##
=========================================
- Coverage   72.24%   69.95%   -2.3%     
=========================================
  Files          15       15             
  Lines         645      689     +44     
  Branches      123      124      +1     
=========================================
+ Hits          466      482     +16     
- Misses        139      164     +25     
- Partials       40       43      +3
Impacted Files Coverage Δ
src/controls/listView/IListView.ts 100% <ø> (ø) ⬆️
src/controls/listView/ListView.tsx 56.56% <36.36%> (-5.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79846a4...6bd0e13. Read the comment docs.

@estruyf estruyf merged commit 6bd0e13 into pnp:dev Dec 19, 2018
@estruyf
Copy link
Member

estruyf commented Dec 19, 2018

Thank you very much @siata13 for this enhancement to the ListView control. I'm sure a lot of DEVs will like it. Keep it coming! 👍

@estruyf estruyf added this to the 1.11.0 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants