Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found - Wrong @fluentui imports cause webpack build errors #1763 #1793

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

raclettierer
Copy link
Contributor

@raclettierer raclettierer commented Mar 19, 2024

Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1763

What's in this Pull Request?

(#1763)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first contribution to this project.

@joelfmrodrigues joelfmrodrigues changed the base branch from master to dev April 18, 2024 11:57
@joelfmrodrigues
Copy link
Collaborator

@raclettierer I'm sorry for the delay on this, has been flagged on my inbox as to-do since you created the PR, but I was busy with the release of a baby 😄
We will try to review soon

@joelfmrodrigues
Copy link
Collaborator

@raclettierer I have updated the target branch to the dev branch. Can you please get the latest version from dev and resolve the conflicts on the PR?

@raclettierer
Copy link
Contributor Author

@joelfmrodrigues : done

@joelfmrodrigues joelfmrodrigues merged commit 052abc1 into pnp:dev Apr 21, 2024
1 check passed
@joelfmrodrigues
Copy link
Collaborator

@raclettierer many thanks, this is now merged

@joelfmrodrigues joelfmrodrigues added this to the 3.18.0 milestone Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants