Field picker list data

[joaojmendes]

Q	A
Bug fix?	[ ]
New feature?	[ X]
New sample?	[ ]
Related issues?	fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

reusable control using @PnP/PnpJs, Office-ui-fabric-react control, that consist of select value as you type from a list column data. This is util when you have large list of items.

[codecov-io]

Codecov Report

Merging #165 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #165   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fa336...7be70aa. Read the comment docs.

[estruyf]

Thanks @joaojmendes for this PR. Always great to receive new controls. I will align this with the current code base. Would it be possible to also add documentation about how to use this control like you can find here: https://github.com/SharePoint/sp-dev-fx-controls-react/tree/master/docs/documentation/docs/controls/fields - Best to do this in a new PR, that way I can do the code changes.

[estruyf]

Merge is completed @joaojmendes for this PR. You can check out the changes I did. Once your documentation PR is in, I can release this version soon after it.

[estruyf]

I did some other changes to the control:

• Moved them to the controls folder, the fields folder is for Field Customizer extension
• Replaced the @pnp/pnpjs code with a simple HTTP call. I really like that you used it, but this makes the footprint of the controls bigger. As it was only used for one call, it is much better to have just a simple Rest call to an API.
• Fixed a bug where you were able to select the item multiple times until the maximum number of items to retrieve was met.

I'm also thinking of renaming the control to ListItemPicker. As that is what the control is providing. What do you think @joaojmendes?

[joaojmendes]

Hi Elio thank you very much for your help and guidance. Yes I agree with your suggestions. Thanks. Obter o Outlook para Android<https://aka.ms/ghei36>

…

________________________________ From: Elio Struyf <[email protected]> Sent: Saturday, October 27, 2018 10:22:18 AM To: SharePoint/sp-dev-fx-controls-react Cc: joaojmendes; Mention Subject: Re: [SharePoint/sp-dev-fx-controls-react] Field picker list data (#165) I did some other changes to the control: * Moved them to the controls folder, the fields folder is for Field Customizer extension * Replaced the @pnp/pnpjs code with a simple HTTP call. I really like that you used it, but this makes the footprint of the controls bigger. As it was only used for one call, it is much better to have just a simple Rest call to an API. * Fixed a bug where you were able to select the item multiple times until the maximum number of items to retrieve was met. I'm also thinking of renaming the control to ListItemPicker. As that is what the control is providing. What do you think @joaojmendes<https://github.com/joaojmendes>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#165 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AL-D1QjUX1r1auVTOg0PqaGu9_tYunaSks5upCXKgaJpZM4X5F44>.

[joaojmendes]

Hi, I created documentation to ListItemPicker control and did some code fixes. Thank you! From: Elio Struyf <[email protected]> Reply-To: SharePoint/sp-dev-fx-controls-react <[email protected]> Date: Saturday, 27 October 2018 at 10:22 To: SharePoint/sp-dev-fx-controls-react <[email protected]> Cc: joaojmendes <[email protected]>, Mention <[email protected]> Subject: Re: [SharePoint/sp-dev-fx-controls-react] Field picker list data (#165) I did some other changes to the control: * Moved them to the controls folder, the fields folder is for Field Customizer extension * Replaced the @pnp/pnpjs code with a simple HTTP call. I really like that you used it, but this makes the footprint of the controls bigger. As it was only used for one call, it is much better to have just a simple Rest call to an API. * Fixed a bug where you were able to select the item multiple times until the maximum number of items to retrieve was met. I'm also thinking of renaming the control to ListItemPicker. As that is what the control is providing. What do you think @joaojmendes<https://github.com/joaojmendes>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#165 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AL-D1QjUX1r1auVTOg0PqaGu9_tYunaSks5upCXKgaJpZM4X5F44>.