Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German localization #142

Closed
wants to merge 3 commits into from
Closed

German localization #142

wants to merge 3 commits into from

Conversation

mmsharepoint
Copy link
Contributor

@mmsharepoint mmsharepoint commented Sep 23, 2018

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

As requested per issue #101 please find the german localization.
Feel free to contact me once new values are needed.

Cheers
Markus ( https://twitter.com/Moeller2_0 )

@codecov-io
Copy link

codecov-io commented Sep 23, 2018

Codecov Report

Merging #142 into dev will decrease coverage by 2.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #142      +/-   ##
==========================================
- Coverage   80.63%   78.38%   -2.25%     
==========================================
  Files          10       10              
  Lines         346      347       +1     
  Branches       78       72       -6     
==========================================
- Hits          279      272       -7     
- Misses         44       55      +11     
+ Partials       23       20       -3
Impacted Files Coverage Δ
src/controls/listView/ListView.tsx 58.21% <0%> (-4.12%) ⬇️
src/controls/placeholder/PlaceholderComponent.tsx 96.66% <0%> (ø) ⬆️
src/common/telemetry/index.ts
src/common/telemetry/version.ts
src/common/appInsights/index.ts 64.7% <0%> (ø)
src/common/appInsights/version.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9eb35e...b914e1a. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Oct 15, 2018

@mmsharepoint thank you very much, but it seems you took an older version so a couple of localizations are missing. Can you add the missing keys from this file: https://github.com/SharePoint/sp-dev-fx-controls-react/blob/dev/src/loc/en-us.ts

@mmsharepoint
Copy link
Contributor Author

Oh, I am sorry.
Of course I can take the new version and provide new translations.

Btw. Do you know an easy way to update my fork (taken some time ago) to the latest version which migh have been the root cause?

Best regards
Markus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants