Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#116 - double click handler, documentation update #123

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Conversation

AJIXuMuK
Copy link
Collaborator

…dated

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? #116

What's in this Pull Request?

onDoubleClick has been added to props interface for FieldNameRenderer
The documentation for FieldNameRenderer has been updated to provide more clear descriptions of the properties.

@codecov-io
Copy link

Codecov Report

Merging #123 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #123   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       71    -7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd4e76...5dc26f1. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Sep 11, 2018

@AJIXuMuK as always, thank you for the PR! Very much appreciated.

@estruyf estruyf merged commit 5dc26f1 into pnp:dev Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants