Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of bug 103 #104

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fix of bug 103 #104

merged 1 commit into from
Aug 9, 2018

Conversation

AJIXuMuK
Copy link
Collaborator

@AJIXuMuK AJIXuMuK commented Aug 4, 2018

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Fix for #103

@codecov-io
Copy link

Codecov Report

Merging #104 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #104      +/-   ##
==========================================
- Coverage   80.63%   80.57%   -0.07%     
==========================================
  Files          10       10              
  Lines         346      350       +4     
  Branches       78       80       +2     
==========================================
+ Hits          279      282       +3     
- Misses         44       46       +2     
+ Partials       23       22       -1
Impacted Files Coverage Δ
src/common/telemetry/index.ts
src/common/telemetry/version.ts
src/common/appInsights/version.ts 100% <0%> (ø)
src/common/appInsights/index.ts 64.7% <0%> (ø)
src/controls/listView/ListView.tsx 63.75% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3358fc...6a8ac04. Read the comment docs.

@estruyf estruyf merged commit a474ca4 into pnp:dev Aug 9, 2018
@estruyf
Copy link
Member

estruyf commented Aug 9, 2018

Thanks @AJIXuMuK for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants