-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New control ModernTaxonomyPicker #1014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@patrikhellgren many thanks for the PR. Could you please resolve the conflicts? |
patrikhellgren
force-pushed
the
modern-taxonomy-picker-2
branch
from
September 24, 2021 08:07
2cbae63
to
af915ea
Compare
patrikhellgren
force-pushed
the
modern-taxonomy-picker-2
branch
from
September 24, 2021 08:18
af915ea
to
76ded80
Compare
@joelfmrodrigues Everything should be resolved now. |
Thanks @patrikhellgren - the PR has been merged! Awesome addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
New control ModernTaxonomyPicker.
Features included:
Searchable terms
Single or multi value tagging with the same display as oob control
Tree view
Handles "Deprecated" terms in the same way as oob control
Handles "Available for tagging" in the same way as oob control
Uses new Term store REST API
Uses paging and "load on demand" to make it work with large term sets in the same way as the oob control. The current sp-dev-fx-controls-react taxonomy picker is not usable with term sets with thousands of terms.
Allows for styling etc. of the term picker which would at least be a start for the request in #996.