Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New control ModernTaxonomyPicker #1014

Merged
merged 19 commits into from
Oct 2, 2021

Conversation

patrikhellgren
Copy link
Contributor

@patrikhellgren patrikhellgren commented Sep 20, 2021

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? mentioned in #965, #996

What's in this Pull Request?

New control ModernTaxonomyPicker.

Features included:

Searchable terms
Single or multi value tagging with the same display as oob control
Tree view
Handles "Deprecated" terms in the same way as oob control
Handles "Available for tagging" in the same way as oob control
Uses new Term store REST API
Uses paging and "load on demand" to make it work with large term sets in the same way as the oob control. The current sp-dev-fx-controls-react taxonomy picker is not usable with term sets with thousands of terms.
Allows for styling etc. of the term picker which would at least be a start for the request in #996.

@joelfmrodrigues
Copy link
Collaborator

@patrikhellgren many thanks for the PR. Could you please resolve the conflicts?

@patrikhellgren patrikhellgren force-pushed the modern-taxonomy-picker-2 branch from 2cbae63 to af915ea Compare September 24, 2021 08:07
@patrikhellgren patrikhellgren force-pushed the modern-taxonomy-picker-2 branch from af915ea to 76ded80 Compare September 24, 2021 08:18
@patrikhellgren
Copy link
Contributor Author

@joelfmrodrigues Everything should be resolved now.

@AJIXuMuK AJIXuMuK merged commit 80e1af1 into pnp:dev Oct 2, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 2, 2021

Thanks @patrikhellgren - the PR has been merged! Awesome addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants