Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFrameDialog Issue #615

Closed
milindsaraswala opened this issue Jul 14, 2020 · 5 comments
Closed

IFrameDialog Issue #615

milindsaraswala opened this issue Jul 14, 2020 · 5 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@milindsaraswala
Copy link

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ v1.19.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Observed Behavior

I am using IFrameDialog from PnP react control in my spfx project. I have use below code on anchor tag in table row. IFrameDialog opens properly on first time click on each row. but when I click second time on the same link than size of the IFrameDialog become very small.

<IFrameDialog
hidden={modalDialog.dialogHide}
url={href}
width={'1000px'}
height={'600px'}
onDismiss={() => setModalDialog({ dialogHide: true })}
modalProps={{ isBlocking: true }}
dialogContentProps={{
type: DialogType.normal,
showCloseButton: true
}}
/>

Thanks!

@ghost
Copy link

ghost commented Jul 14, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 14, 2020
@milindsaraswala
Copy link
Author

According to my test results, this should be a problem with this control.

My test result:

When we first open a dialog, the outermost div of the control will have such a piece of CSS code.

1608965

This CSS code disappeared when we closed the dialog and opened it again.

1608967

This control has a default max-width,so the dialog becomes smaller.

1608968

@ghost
Copy link

ghost commented Jul 22, 2020

Also experiencing this bug.

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 8, 2020

Thank you @milindsaraswala for reporting the issue.
We will be working on fixing it.

In a meanwhile you can modify you code:

{!modalDialog.dialogHide && <IFrameDialog
  hidden={modalDialog.dialogHide}
  url={href}
  width={'1000px'}
  height={'600px'}
  onDismiss={() => setModalDialog({ dialogHide: true })}
  modalProps={{ isBlocking: true }}
  dialogContentProps={{
    type: DialogType.normal,
    showCloseButton: true
  }}
/>}

It will re-add the dialog each time when it should be displayed and will fix the issue.

@AJIXuMuK AJIXuMuK added status:tracked Triaged and are being investigated further type:bug and removed Needs: Triage 🔍 labels Aug 8, 2020
AJIXuMuK added a commit that referenced this issue Aug 25, 2020
@AJIXuMuK
Copy link
Collaborator

This one has been fixed and will be included in the next release.
In a meanwhile you can test the functionality in beta version

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:tracked Triaged and are being investigated further labels Aug 25, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

2 participants