Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IFrameDialog] Loader (Spinner) is appears constantly #154

Closed
PooLP opened this issue Oct 19, 2018 · 5 comments
Closed

[IFrameDialog] Loader (Spinner) is appears constantly #154

PooLP opened this issue Oct 19, 2018 · 5 comments
Milestone
1.11.0

Comments

@PooLP
Copy link
Contributor

PooLP commented Oct 19, 2018

Category

[ x] Enhancement

[ X] Bug

[ ] Question

Version 1.9.0

Hi,
there is a bug in IFrameDialog, the loader (spinner) is appears constantly (bug appear only in 1.9.0) :

iframe

I have another suggestion, is it possible to add an option to add parameters to the iframe ?

ex for youtube embed to add "allowfullscreen" parameters:

<iframe src = "//www.youtube.com/embed/fgdvd4545?autoplay=1" allowfullscreen>

Thanks
@estruyf
Copy link
Member

estruyf commented Nov 5, 2018

@AJIXuMuK could you check this one?

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Nov 5, 2018

Will look into it

AJIXuMuK pushed a commit to AJIXuMuK/sp-dev-fx-controls-react that referenced this issue Nov 6, 2018
Issue pnp#154
07c32fd
@AJIXuMuK AJIXuMuK mentioned this issue Nov 6, 2018
Merged
@estruyf estruyf added this to the 1.11.0 milestone Dec 7, 2018
@estruyf
Copy link
Member

estruyf commented Dec 7, 2018

@PooLP fix for this will be included in version 1.11.0 thanks to @AJIXuMuK.

@estruyf estruyf added the bug label Dec 7, 2018
@PooLP
Copy link
Contributor Author

PooLP commented Dec 10, 2018

Thanks @AJIXuMuK

@estruyf estruyf mentioned this issue Dec 21, 2018
Merged
@estruyf
Copy link
Member

estruyf commented Dec 21, 2018

This has been released with the latest 1.11.0 version. Feel free to test it out, and you can reopen the issue if it still occurs.

@estruyf estruyf closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
3 participants
@PooLP @estruyf @AJIXuMuK