-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some new Features #859
Conversation
…ission context can create a team site
…ccesable by developers
Codecov Report
@@ Coverage Diff @@
## dev #859 +/- ##
==========================================
+ Coverage 82.42% 83.39% +0.97%
==========================================
Files 416 559 +143
Lines 28590 36271 +7681
==========================================
+ Hits 23565 30248 +6683
- Misses 5025 6023 +998
Continue to review full report at Codecov.
|
Thanks for the contributions @danielpastoor 💪 |
Thanks for the PR @danielpastoor . I've merged this one, but did do quite some changes, maybe you want to have a look at 0deb3db to understand what I've changed. Key changes are:
But please don't get me wrong here, super happy to these contributions come in as they add value for folks using the SDK. Taking in account above recommendations will help speed up merging of future PRs :-) |
@jansenbe Thank you for the feedback. I see this as a learning curf for me. And I will improve the my coding for the next time. Thanks |
I added some new features.
Features:
1.
Check if a site exists by alias and full url
2.
Added option to create a team site when you use "Application" permissions.
3.
Changed TeamChannelTabConstants.cs location from internal to public so people can use it in there own projects.