Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry handler to authentication providers #656

Merged

Conversation

patrikhellgren
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues?

What's in this Pull Request?

Added Msal Http Client Factory with retry handler to authentication providers.

@codecov-commenter
Copy link

Codecov Report

Merging #656 (b7b24f2) into dev (c13436b) will increase coverage by 7.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #656      +/-   ##
==========================================
+ Coverage   75.32%   82.45%   +7.12%     
==========================================
  Files         257      414     +157     
  Lines       19708    28536    +8828     
==========================================
+ Hits        14846    23529    +8683     
- Misses       4862     5007     +145     
Impacted Files Coverage Δ
...del/SharePoint/Core/Internal/FieldLocationValue.cs 0.00% <0.00%> (-35.49%) ⬇️
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 62.06% <0.00%> (-26.17%) ⬇️
...h/Public/UsernamePasswordAuthenticationProvider.cs 68.60% <0.00%> (-25.52%) ⬇️
...P.Core/QueryModel/Query/BaseDataModelExtensions.cs 38.88% <0.00%> (-23.07%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamIdentitySet.cs 50.00% <0.00%> (-16.67%) ⬇️
src/sdk/PnP.Core/Utilities/StringExtensions.cs 85.07% <0.00%> (-14.93%) ⬇️
.../Model/Teams/Internal/TeamChatMessageAttachment.cs 85.71% <0.00%> (-14.29%) ⬇️
...nP.Core/Services/Core/Http/SharePointRestClient.cs 70.37% <0.00%> (-12.24%) ⬇️
...e/Model/SharePoint/Core/Internal/StorageMetrics.cs 77.77% <0.00%> (-9.73%) ⬇️
.../PnP.Core/QueryModel/Query/ExpressionExtensions.cs 91.30% <0.00%> (-8.70%) ⬇️
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1501583...b7b24f2. Read the comment docs.

@jansenbe jansenbe self-assigned this Nov 24, 2021
@jansenbe jansenbe added the area: framework ⚙ Changes in the SDK core framework code label Nov 24, 2021
jansenbe added a commit that referenced this pull request Nov 24, 2021
@jansenbe jansenbe merged commit b660970 into pnp:dev Nov 24, 2021
@patrikhellgren patrikhellgren deleted the add-retry-handler-to-authentication-providers branch December 3, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework ⚙ Changes in the SDK core framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants