Fixing problem with "new Guid()" inside LINQ expressions. #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #632
The idea is to compile lambda expression with
new Guid()
and invoke compiled delegate to get a real Guid instance:I searched for any info about
Expression.Compile()
performance and found this SO answer, which indicates that performance is very good (600-700ms for 2M of iterations). I checked results on my own environment for .NET 5 and received similar results. Invoking a compiled delegate is also fast.