Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where adding items to the root site collection resulted in a 404 #470

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

DaleyKD
Copy link
Contributor

@DaleyKD DaleyKD commented Jun 1, 2021

This is to help fix #312 .

We were adding a double-slash in the list URL (e.g. - "https://gimmalkyle2.sharepoint.com//lists/MyTest")

Question for:

                // Drop List suffix
                listUrl = listUrl.Substring(0, listUrl.Length - 4);
                return $"{contextUrl}/lists/{listUrl}";

I see we're stripping off "List" from the end using the .Substring(). However, if the language is anything other than English, does that matter (I know it's coming from the OData_ property bag values)?

@codecov-commenter
Copy link

Codecov Report

Merging #470 (e4f6f72) into dev (c13436b) will increase coverage by 3.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #470      +/-   ##
==========================================
+ Coverage   75.32%   79.13%   +3.80%     
==========================================
  Files         257      333      +76     
  Lines       19708    22834    +3126     
==========================================
+ Hits        14846    18070    +3224     
+ Misses       4862     4764      -98     
Impacted Files Coverage Δ
...e.Auth/Public/InteractiveAuthenticationProvider.cs 70.00% <100.00%> (+3.80%) ⬆️
...del/SharePoint/Core/Internal/FieldLocationValue.cs 0.00% <0.00%> (-35.49%) ⬇️
...h/Public/UsernamePasswordAuthenticationProvider.cs 68.23% <0.00%> (-25.89%) ⬇️
...P.Core/QueryModel/Query/BaseDataModelExtensions.cs 38.88% <0.00%> (-23.07%) ⬇️
.../Model/Teams/Internal/TeamChatMessageAttachment.cs 85.71% <0.00%> (-14.29%) ⬇️
...rc/sdk/PnP.Core/Services/Core/Query/QueryClient.cs 77.97% <0.00%> (-7.88%) ⬇️
....Core/QueryModel/Query/DataModelQueryTranslator.cs 77.61% <0.00%> (-7.11%) ⬇️
...sdk/PnP.Core/Model/Base/BaseDataModelCollection.cs 56.85% <0.00%> (-7.11%) ⬇️
.../PnP.Core/QueryModel/Query/ExpressionExtensions.cs 94.44% <0.00%> (-5.56%) ⬇️
...nP.Core/Services/Core/Http/MicrosoftGraphClient.cs 75.00% <0.00%> (-5.00%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d5fec...e4f6f72. Read the comment docs.

@jansenbe jansenbe self-assigned this Jun 2, 2021
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Jun 2, 2021
jansenbe added a commit that referenced this pull request Jun 2, 2021
@jansenbe jansenbe merged commit af0f310 into pnp:dev Jun 2, 2021
@DaleyKD DaleyKD deleted the iss312 branch June 2, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I'm trying to add list items in a simple site.. but keep getting Invalid file name error:
3 participants