#1365 #1369 prevent crash on image and location columns #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2024 16:18
…d image columns properly
…h_on_image_and_location_columns
wizofaus
commented
Mar 2, 2024
| return this; | ||
| } | ||
|
|
||
| internal override object ToJson() |
There was a problem hiding this comment.
incomplete as I'm not sure when this is used
wizofaus
commented
Mar 2, 2024
| @@ -692,6 +693,10 @@ private static object GetJsonPropertyValue(JsonElement propertyValue, FieldType | |||
| { | |||
| return null; | |||
| } | |||
| else if (propertyValue.ValueKind == JsonValueKind.Object) | |||
| { | |||
| return propertyValue.ToObject<System.Dynamic.ExpandoObject>(); | |||
There was a problem hiding this comment.
this is a "just in case" for other field types that happen to be treated as objects
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #1411 +/- ##
==========================================
- Coverage 82.42% 81.60% -0.83%
==========================================
Files 416 624 +208
Lines 28590 43720 +15130
Branches 0 4579 +4579
==========================================
+ Hits 23565 35677 +12112
- Misses 5025 6697 +1672
- Partials 0 1346 +1346 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit test will only work with mocked data or if you explicitly create list on your site with correct columns