Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(role assignments): incorrect url for getting by principal id #1207

Merged

Conversation

JakeStanger
Copy link

Fixes the incorrect call on role assignments when getting by principal id:

_api/web/roleAssignments/getByPrincipal(10)

to the correct:

_api/web/roleAssignments/getByPrincipalId(10)

Fixes the incorrect call on role assignments when getting by principal id:

```cs
_api/web/roleAssignments/getByPrincipal(10)
```

to the correct:

```cs
_api/web/roleAssignments/getByPrincipalId(10)
```
@jansenbe jansenbe self-assigned this Jun 15, 2023
@jansenbe jansenbe added bug Something isn't working area: model 📐 Related to the core SDK models labels Jun 15, 2023
@jansenbe
Copy link
Contributor

Nice find @JakeStanger , appreciate the PR with the fix. There indeed is no "GetPrincipal" method on the RoleAssignments collection in SP REST.

jansenbe added a commit that referenced this pull request Jun 15, 2023
@jansenbe jansenbe merged commit bddba1d into pnp:dev Jun 15, 2023
@JakeStanger JakeStanger deleted the fix/role-assignment-get-by-principal-id branch June 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants