Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with text web part not update the previw text in the News web part #765

Closed
1 task done
greenfox75 opened this issue Feb 19, 2022 · 2 comments
Closed
1 task done
Assignees
Labels
area: pages API 📄 Working with modern pages question Further information is requested

Comments

@greenfox75
Copy link

greenfox75 commented Feb 19, 2022

Category

  • Bug

Describe the bug

I added the news web part in my site home page for show my custom page created by code.
After created my custom page where I have added text web part with text.
I updated the text in the text web part.
The preview of the text in the News web part not updated the text.

Steps to reproduce

Add in home page a News web part. Setting the news web part with layout 'side by side'.
Create by code custom news with web part text and custom text and publish.
After check the news web part and remember the text of the web part in the preview text.
Update the text in the news web part and republish the news.
Return on the home page and check the preview. The text preview in the news web part not updated.

Expected behavior

That when The user update the text in web part created by code the preview in the web part News update the text.

Environment details (development & target environment)

SDK version: [1.5.0]
OS: [e.g. Windows 10]
SDK used in: [Console application]
Framework: [NET Framework 4.8 ]
Browser(s): [Goggle Crome]
Tooling: [ Visual Studio 2019]
Additional details: Check next section details.

Additional context

SharePoint online

@jansenbe jansenbe added area: pages API 📄 Working with modern pages question Further information is requested labels Feb 20, 2022
@jansenbe
Copy link
Contributor

See also #790

@jansenbe jansenbe self-assigned this Mar 28, 2022
jansenbe added a commit that referenced this issue Mar 28, 2022
…ription, subsequent user page edits will then override this description. This aligns with the OOB behavior and fixes #790 and #765
@jansenbe
Copy link
Contributor

@greenfox75 : I've just committed a fix for this. Now the behavior aligns with what you would get for a manually created page. When a page is created the library sets a default description, but leaves it marked as "default"...when a user then edits the page the description is overwritten depending on the user's edits and this should also reflect in roll up web parts (search/caching might delay this a bit).

Note, when programmatically updating a page we're not overwriting the existing description if any was set. We do respect the default description flag if it was set before, so a page that was given a custom description via the UI will stay in that mode on page edit.

For now we do not offer an option to change a custom description, if you feel that's needed then let me know.

Note that I'm also closing this case for now, please try with the next nightly (or 1.6 which we hope to release soon) and if you still see issues then please re-open or create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: pages API 📄 Working with modern pages question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants