Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new Section Properties in Client Side Pages #539

Closed
1 task done
czullu opened this issue Sep 8, 2021 · 3 comments
Closed
1 task done

Support for new Section Properties in Client Side Pages #539

czullu opened this issue Sep 8, 2021 · 3 comments
Assignees
Labels
area: pages API 📄 Working with modern pages

Comments

@czullu
Copy link

czullu commented Sep 8, 2021

Category

  • Feature request

Describe the feature

In order to support new sections settings in Client Side Pages we should add support for those new settings into PnP.Core\Model\SharePoint\Pages\Internal\CanvasControlData.cs

"zoneGroupMetadata": {
	"type": 1,
	"displayName": "Docs",
	"isExpanded": true,
	"iconAlignment": "right",
	"showDividerLine": true
},
"reservedHeight": 693,
"reservedWidth": 1180
@jansenbe jansenbe self-assigned this Sep 9, 2021
@jansenbe jansenbe added the area: pages API 📄 Working with modern pages label Sep 9, 2021
@czullu
Copy link
Author

czullu commented Sep 9, 2021

@jansenbe just seen MC266077 - you might have more info if there will be some upcoming changes to this settings

@jansenbe
Copy link
Contributor

jansenbe commented Sep 9, 2021

@czullu : support for collapsible sections has been added, see https://github.com/pnp/pnpcore/blob/dev/src/sdk/PnP.Core.Test/SharePoint/PagesTests.cs#L790-L873 for a test showing how to use them. Docs (https://pnp.github.io/pnpcore/using-the-sdk/pages-intro.html) are also updated.

Please give this a try with tomorrow's build and let me know if you face issues.

@czullu
Copy link
Author

czullu commented Sep 9, 2021

@jansenbe looks good to me. could read and change the settings - even the crazy title test was ok.
image
Thank you

@jansenbe jansenbe closed this as completed Sep 9, 2021
heinrich-ulbricht added a commit to WikiTransformationProject/pnpcore that referenced this issue Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: pages API 📄 Working with modern pages
Projects
None yet
Development

No branches or pull requests

2 participants