Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the IWeb WebTemplatesGalleryFirstRunEnabled property #1057

Closed
1 task done
plamber opened this issue Dec 13, 2022 · 6 comments
Closed
1 task done

Add support to the IWeb WebTemplatesGalleryFirstRunEnabled property #1057

plamber opened this issue Dec 13, 2022 · 6 comments
Assignees
Labels
area: model 📐 Related to the core SDK models

Comments

@plamber
Copy link
Contributor

plamber commented Dec 13, 2022

Category

  • Domain model extension

Describe the domain model extension

The IWeb already supports the boolean property to manage the first run of the next steps wizard through NextStepsFirstRunEnabled. Another property called WebTemplatesGalleryFirstRunEnabled controls if the web template gallery should be displayed. Latter is missing in IWeb.

Additional Information

Properties can be controlled with these examples:

@plamber
Copy link
Contributor Author

plamber commented Dec 13, 2022

Do you have a recommendation how to temporarily add a batch request for a missing property until the SDK is supporting this?

@jansenbe
Copy link
Contributor

@plamber : adding this one right now, can trigger an extra nightly build if you need it today

@jansenbe jansenbe self-assigned this Dec 13, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Dec 13, 2022
@plamber
Copy link
Contributor Author

plamber commented Dec 13, 2022

Would be awesome. Would this be the right approach to patch the Web and add it as Batch?

string body = SerializeJSON(new
{
    WebTemplatesGalleryFirstRunEnabled = false
});
var accessRequest = new ApiRequest(HttpMethod.Patch, ApiRequestType.SPORest, "_api/web", body);
web.ExecuteRequestBatch(accessRequest);

jansenbe added a commit that referenced this issue Dec 13, 2022
…ebTemplatesGalleryFirstRunEnabled` property on `IWeb` #1057
@jansenbe
Copy link
Contributor

See https://pnp.github.io/pnpcore/using-the-sdk/basics-customapirequests.html#batching-custom-api-requests for the batching of custom API calls.

I've just pushed the change, if you can wait for 30 minutes there's a new nightly release that contains this, so then you don't need to fall back to a custom API call

@jansenbe
Copy link
Contributor

Nightly nuget release running, when you see version 1.8.37 appearing then that's the version that contains this change

@plamber
Copy link
Contributor Author

plamber commented Dec 13, 2022

Thank you. Highly appreciated

@plamber plamber closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

No branches or pull requests

2 participants