Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ABDH generator #121

Closed
wants to merge 3 commits into from

Conversation

roman-timo
Copy link

added ABCDH model generator a ./hypernetx/utils/
modified class Hypergraph - added method from_abcdh

@roman-timo roman-timo marked this pull request as draft August 20, 2023 23:37
@brendapraggastis brendapraggastis self-requested a review August 22, 2023 20:43
@brendapraggastis brendapraggastis self-assigned this Aug 22, 2023
@bonicim
Copy link
Collaborator

bonicim commented Aug 23, 2023

Please ignore the GH Workflow failure for Docs. There is a bug in that workflow and I will fix it in a later release.

On the run-tests workflow, it failed our precommit hooks because your code failed our Python formatter check; HNX uses Black for a consistent format. See the Code Quality section of our Readme for instructions on how to format your code locally so that it passes the CI pipeline on Github Workflows.

@bonicim bonicim changed the base branch from master to develop August 23, 2023 23:01
@bonicim
Copy link
Collaborator

bonicim commented Aug 23, 2023

Changing destination branch to 'develop'. In the future, please use 'develop' as the destination branch for all future PR's. Thanks in advance.

@bkamins
Copy link

bkamins commented Aug 24, 2023

@roman-timo - are you planning to port the source code of ABCD-H to Python (so that no integration with Julia is needed?)

@brendapraggastis
Copy link
Collaborator

We would prefer to have a separate module with ABCDH generation available both from Python and Julia. Please see hypernetx/algorithms/generative_models.py for examples of how this was done in pure Python.

@roman-timo
Copy link
Author

@roman-timo - are you planning to port the source code of ABCD-H to Python (so that no integration with Julia is needed?)

Yes, I'm planning to convert this ABCD-H generator to Python first, so that no issues with Julia integration.
It will take some time.. Once it is ready, I will mark this PR as "Ready". Please ignore the "Draft" mode for now :)

Thanks for support!

@brendapraggastis
Copy link
Collaborator

@roman-timo Closing until new code is ready.

bonicim added a commit that referenced this pull request Nov 3, 2023
Merge in HYP/hypernetx from fix-ci-pipeline-docs to develop

* commit '2656a06f01669ffb696daa48d66f9bf8bc12c5b6':
  Fix github workflow for documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants