Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: change python-igraph to igraph #117

Merged
merged 2 commits into from
Jul 24, 2023
Merged

dependencies: change python-igraph to igraph #117

merged 2 commits into from
Jul 24, 2023

Conversation

szhorvat
Copy link
Contributor

Please see igraph/python-igraph#699 for an explanation.

bonicim and others added 2 commits June 28, 2023 17:58
@bonicim @brendapraggastis
Pull request pnnl#98: Releases/v2.0.2
9e5a277 
Merge in HYP/hypernetx from releases/v2.0.2 to master

* commit 'dd76f358ef5d6f2b76c24260bb7edb6ad4ac98c0':
  bump: version 2.0.1 → 2.0.2
  Fix import try catch block; update pypi workflow
@szhorvat
dependencies: change python-igraph to igraph
4ddacd0
@bonicim bonicim assigned bonicim and unassigned bonicim Jul 24, 2023
@bonicim bonicim self-requested a review July 24, 2023 15:17
bonicim
bonicim reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@bonicim bonicim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing destination branch to develop. PR's should target the develop branch; will update Contribution guidance to make this more clear. Thanks for the PR and support!

@bonicim bonicim changed the base branch from master to develop July 24, 2023 15:26
bonicim
bonicim approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@bonicim bonicim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Although the Documentation workflow failed, that is result is a false positive. I will update the workflow on the next release to fix that issue.

@bonicim bonicim merged commit 44a2a8b into pnnl:develop Jul 24, 2023
bonicim added a commit that referenced this pull request Oct 26, 2023
@bonicim
Pull request #117: Update classes based on changes from testing
2b7425e 
Merge in HYP/hypernetx from HYP-177-cherry-pick to develop

* commit 'fd25bb5ff6d9b9b8f53159c4185db232667606d2':
  Update classes based on changes from testing
@szhorvat szhorvat mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonicim bonicim bonicim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szhorvat @bonicim