Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LICENSE is not clearly OSI compliant #127

Closed
drj11 opened this issue Nov 30, 2023 · 2 comments
Closed

The LICENSE is not clearly OSI compliant #127

drj11 opened this issue Nov 30, 2023 · 2 comments
Assignees

Comments

@drj11
Copy link

drj11 commented Nov 30, 2023

Describe the bug

LICENSE is provided in LICENSE.rst but it not clearly OSI compliant.

Additional context

I am reviewing this package for JOSS openjournals/joss-reviews#6016 (comment)

It looks like the license is intended to be the BSD 3-clause license (at OSI here: https://opensource.org/license/bsd-3-clause/ ) but:

  • there is a typo at the end of the 2nd clause which currently reads "and/or other" but should read "and/or other materials provided with the distribution."
  • the third clause has been edited in a way as to make it unclear if it still matches the BSD 3-clause license. In particular "Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software" has been changed to "neither the name Battelle Memorial Institute or Battelle may be used in any form whatsoever without the express written consent of Battelle.".

The modification to clause 3 appears to be a substantial reduction in the grant.

I suggest that you either:

  • use the BSD 3-clause license directly; or,
  • provide enough material to reviewers to assure us that this license is in fact "the contents of an OSI approved software license"
@danielskatz
Copy link

For JOSS to review the work, it has to have an OSI-compliant license, which means that the license can't be a variation of an OSI license, but actually an OSI license.

@bonicim bonicim self-assigned this Dec 4, 2023
@brendapraggastis
Copy link
Collaborator

@danielskatz @drj11 We updated the license to standard verbiage. Thanks for the catch.

@bonicim bonicim closed this as completed Dec 4, 2023
bonicim added a commit that referenced this issue Feb 28, 2024
Merge in HYP/hypernetx from hotfix/update-modularity-docs to develop

* commit '225f584fbcb10ec5fb2ba299b3adffd6c9e05183':
  bump: version 2.1.0 → 2.1.1
  Update modularity docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants