Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack GitHub action #15

Merged
merged 21 commits into from
Sep 26, 2023
Merged

Spack GitHub action #15

merged 21 commits into from
Sep 26, 2023

Conversation

cameronrutherford
Copy link
Contributor

@cameronrutherford cameronrutherford commented Sep 22, 2023

This modifies exago's spack package, so spack/spack#40188 should be merged before this, and submodule updated accordingly.

Closes #11

Copy link
Contributor Author

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we still have other work to do with submodules, these builds should catch some errors we are seeing in xSDK pipelines and so are useful in their current state. This will be improved in the future.

.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
.github/workflows/spack_cpu_build.yaml Outdated Show resolved Hide resolved
@cameronrutherford cameronrutherford mentioned this pull request Sep 22, 2023
20 tasks
@cameronrutherford
Copy link
Contributor Author

Currently each of the spack builds take at least 30min of GitHub runner time, so we should both minimize the set of configurations we test, and also try to only run CI infrequently (maybe only on merges into develop from now on?)

@cameronrutherford
Copy link
Contributor Author

https://github.com/pnnl/ExaGO/actions/runs/6279332431/job/17054811101?pr=15 - really interesting bug here. This is probably one of the first times that someone has built exago in this minimal config, so we have an error that we don't import os in our package.

Normally something like hiop or another package would conveniently import this for us, but we finally hit a build configuration where this wasn't the case :)

See spack PR for the fix that is used in this PR (ideally Spack PR is merged before this) spack/spack#40188

@cameronrutherford
Copy link
Contributor Author

xsdk-project/xsdk-issues#220 - finally reproduced this issue in the pipelines here. Just a matter of actually fixing the issue now.

@cameronrutherford
Copy link
Contributor Author

@ryandanehy and @abhyshr I think this is ready to go when CI passes, so I would love at least one more review of this finished product before merging.

This also resolves issues with xSDK build failures, so good to get this merged soon.

@cameronrutherford
Copy link
Contributor Author

See #17 for issue identified when building exago~tests

@cameronrutherford
Copy link
Contributor Author

See #18 and LLNL/hiop#662 for issues with exago~mpi+hiop

Copy link
Collaborator

@abhyshr abhyshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cameronrutherford cameronrutherford merged commit 18f0824 into develop Sep 26, 2023
11 checks passed
@cameronrutherford cameronrutherford added this to the 1.6.0 Release milestone Oct 11, 2023
cameronrutherford added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU only build of ExaGO in GitHub actions
2 participants