-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON schemas #42
Merged
Merged
JSON schemas #42
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d70259d
add Json schema files
Fan-Feng dee02a1
Added new schemas and test file
jslane-h ea88e49
Added jsonschema requirement
jslane-h 9a3d0b9
Removed $id's
jslane-h 778811b
JSON schema updates
jslane-h 062ee3e
Updated schema path
jslane-h 2e2b521
Removed maximum from library_item_id schema
jslane-h 4b3d839
Merge branch 'develop' into ext_lgt_daylight_off_control
leijerry888 946a9a6
update schema to align with previous cases
leijerry888 f3ff61e
Merge branch 'develop' into Jsonschema
leijerry888 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"type": "object", | ||
"properties": { | ||
"library_item_id": { | ||
"type": "integer", | ||
"minimum": 1 | ||
}, | ||
"description_brief": { | ||
"type": "string" | ||
}, | ||
"description_detailed": { | ||
"type": "string" | ||
}, | ||
"description_index": { | ||
"type": "array", | ||
"items": { | ||
"type": "string" | ||
} | ||
}, | ||
"description_datapoints": { | ||
"type": "object" | ||
}, | ||
"description_assertions": { | ||
"type": "array", | ||
"items": { | ||
"type": "string" | ||
} | ||
}, | ||
"description_verification_type": { | ||
"enum": [ | ||
"rule-based", | ||
"procedure-based" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm fine with just these for now since that we don't have any |
||
] | ||
}, | ||
"assertions_type": { | ||
"enum": [ | ||
"pass", | ||
"fail" | ||
] | ||
} | ||
}, | ||
"required": [ | ||
"library_item_id", | ||
"description_brief", | ||
"description_detailed", | ||
"description_index", | ||
"description_datapoints", | ||
"description_verification_type", | ||
"assertions_type" | ||
], | ||
"additionalProperties": false | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we missing
description_assertions
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. Just added that