fix skeleton representation conditions + fix representation syncing on dedicated servers #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Berthalamew
commented
Oct 24, 2023
Berthalamew
commented
- would set the skeleton representation regardless of if the event was active
- fix custom representation syncing on dedicated servers
- update special events enum
- update and move player representation code
- would set the skeleton representation regardless of if the event was active - update special events enum
- misc changes so it uses the character type enum define instead of a typemap
- fix custom variants on dedis
- syncing variants has the unintended consequence of exposing another issue with our hacky player representation solution for servers - we should really fix tag injection on servers so we don't have to write patches like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.