Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/smart contract #68

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Fix/smart contract #68

merged 5 commits into from
Feb 26, 2024

Conversation

envin3
Copy link
Collaborator

@envin3 envin3 commented Feb 25, 2024

fix bug in checking if address belong to a smart contract
image

@envin3 envin3 requested a review from oliviera9 February 25, 2024 18:37
@envin3 envin3 marked this pull request as ready for review February 26, 2024 09:10
oliviera9
oliviera9 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unused function in the test, then LGTM!

@oliviera9
Copy link
Contributor

Also remember to bump patch number.

@envin3 envin3 merged commit 929f060 into master Feb 26, 2024
4 checks passed
@envin3 envin3 deleted the fix/smartContract branch February 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviera9 oliviera9 oliviera9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envin3 @oliviera9