Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ethPNT): support ethPNT #61

Merged
merged 8 commits into from
Jan 29, 2024
Merged

feat(ethPNT): support ethPNT #61

merged 8 commits into from
Jan 29, 2024

Conversation

envin3
Copy link
Collaborator

@envin3 envin3 commented Nov 27, 2023 •
edited
Loading

  • Update algorand node
  • Add check to migrate destination address
  • Update Telos Logo
  • Add support for PNT swaps using ethPNT token.
    ethPNT is an extension of PNT contract; it can be used by switching a toggle after PNT token have been selected:
    image

@envin3 envin3 requested a review from oliviera9 November 27, 2023 09:59
@envin3 envin3 force-pushed the feat/ethPNT-support branch 3 times, most recently from 09436c7 to c6e1a2a Compare November 28, 2023 09:18
@oliviera9
Copy link
Contributor

What's the motivation behind this PR? What's the need?

@envin3
Copy link
Collaborator Author

envin3 commented Nov 29, 2023

What's the motivation behind this PR? What's the need?

It has been requested to support ethPNT directly in the swaps in a similar way to PNT.

@envin3 envin3 force-pushed the feat/ethPNT-support branch 4 times, most recently from 087757b to d9d6e58 Compare January 23, 2024 18:03
oliviera9
oliviera9 reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things I didn't understand completely.

src/utils/ptokens.js Outdated Show resolved Hide resolved
src/components/organisms/swapLine/SwapLine.jsx Show resolved Hide resolved
src/components/organisms/swapLine/SwapLine.jsx Show resolved Hide resolved
src/utils/swap-valildator.js Outdated Show resolved Hide resolved
src/utils/ptokens.js Outdated Show resolved Hide resolved
src/utils/__tests__/swap-valildator.test.js Outdated Show resolved Hide resolved
src/store/swap/swap.actions.js Outdated Show resolved Hide resolved
src/settings/swap-assets.js Show resolved Hide resolved
src/settings/swap-assets.js Show resolved Hide resolved
src/hooks/use-assets.js Show resolved Hide resolved
@envin3 envin3 force-pushed the feat/ethPNT-support branch from d9d6e58 to 044089e Compare January 25, 2024 18:57
oliviera9
oliviera9 reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready! Check few comments.

src/utils/__tests__/swap-valildator.test.js Show resolved Hide resolved
src/utils/__tests__/ptokens.test.js Outdated Show resolved Hide resolved
src/components/organisms/swapLine/SwapLine.jsx Outdated Show resolved Hide resolved
src/components/organisms/swapLine/SwapLine.jsx Show resolved Hide resolved
@envin3 envin3 force-pushed the feat/ethPNT-support branch 3 times, most recently from e440cbf to 940904f Compare January 29, 2024 14:20
@envin3 envin3 force-pushed the feat/ethPNT-support branch from 940904f to 15c3868 Compare January 29, 2024 14:23
oliviera9
oliviera9 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good job

@envin3 envin3 merged commit 12ffbd8 into master Jan 29, 2024
4 checks passed
@envin3 envin3 deleted the feat/ethPNT-support branch January 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviera9 oliviera9 oliviera9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envin3 @oliviera9