Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sentinel-lib): Add support to generic event signing #30

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ubordignon
Copy link
Contributor

No description provided.

@ubordignon ubordignon requested review from envin3 and gitmp01 May 16, 2024 08:33
Copy link
Contributor

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, rest LGTM

@@ -163,6 +163,7 @@ mod tests {
fn should_get_config() {
let path = "src/config/test_utils/sample-config";
let result = SentinelConfig::new(path);
assert!(result.is_ok());
result.unwrap();
//assert!(result.is_ok());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this commented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants