feat(v2-eos-cores): <- allow those to work with multi incremerkles #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` for saving in db'
…with `Incremerkles`
gskapka
force-pushed
the
multi-incremerkles
branch
from
0a846e0 to
b6ada32
Compare
gskapka
force-pushed
the
multi-incremerkles
branch
from
b6ada32 to
235d9a3
Compare
…ng protection works w/ multi-incremerkle based submission
gskapka
force-pushed
the
multi-incremerkles
branch
from
b190fb7 to
0bb6ff6
Compare
ubordignon
reviewed
Feb 14, 2024
ubordignon
reviewed
Feb 14, 2024
Co-authored-by: ubordignon <[email protected]>
gskapka
force-pushed
the
multi-incremerkles
branch
from
d9ca52a to
063e466
Compare
|
Awaiting testing on prod before merging. |
…ot currently parsable
gskapka
force-pushed
the
multi-incremerkles
branch
from
7d70e0f to
3d427e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...per title.
The eos cores now store up to X previous incremerkles, allowing for submission material to contains proofs that reference any of those rather than just the chain tip.
This is to help mitigate the race condition that sometimes occurs between the two nodes used for eos cores, one for getting blocks and the other for actions.
If the action is slow to appear on the end point, occasionally the core's incremerkle can have been updated in the meanwhile, moving it beyond the block the action (when it appears) was dispated in. This leaves the submission stuck.
Now however, the cores when asked about their latest block numbers, return an array of options that the eos-syncer may chose from in order to correctly proof an action w/r/t to a block the core knows about.