Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes32 for the Adapter underlying token #74

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

envin3
Copy link
Contributor

@envin3 envin3 commented Nov 19, 2024

Use bytes32 to support non EVM underlying tokens in the Adapter.

@envin3 envin3 requested a review from gitmp01 November 19, 2024 11:46
@envin3 envin3 changed the title Fix/eos underlying Use bytes32 for the Adapter underlying token Nov 19, 2024
Copy link
Collaborator

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment then LGTM!

solidity/src/contracts/Adapter.sol Outdated Show resolved Hide resolved
@envin3 envin3 force-pushed the fix/eos-underlying branch 3 times, most recently from 1841659 to 8a6a46f Compare November 20, 2024 16:01
solidity/src/contracts/Adapter.sol Outdated Show resolved Hide resolved
@envin3 envin3 force-pushed the fix/eos-underlying branch from 6bdee7b to 36da8bb Compare November 20, 2024 17:17
@envin3 envin3 force-pushed the fix/eos-underlying branch from 36da8bb to 1c75a39 Compare November 20, 2024 17:24
Copy link
Collaborator

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@envin3 envin3 merged commit 9b85901 into master Nov 20, 2024
1 check passed
@envin3 envin3 deleted the fix/eos-underlying branch November 20, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants