Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOS on chain event parsing (3/4) #52

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

gitmp01
Copy link
Collaborator

@gitmp01 gitmp01 commented Nov 4, 2024

Notes:

  • PAM.isAuthorized() ~ 1.8M gas

@gitmp01 gitmp01 changed the base branch from master to chore/add-pam-test-suite November 4, 2024 17:29
@gitmp01 gitmp01 force-pushed the fix/eos-onchain-event-parsing branch from 6ffaf0f to e679b09 Compare November 4, 2024 17:31
@gitmp01 gitmp01 requested a review from envin3 November 5, 2024 14:23
@gitmp01 gitmp01 changed the title Add EOS on chain event parsing Add EOS on chain event parsing (3/3) Nov 5, 2024
@gitmp01 gitmp01 changed the title Add EOS on chain event parsing (3/3) Add EOS on chain event parsing (3/4) Nov 6, 2024
@gitmp01 gitmp01 force-pushed the chore/add-pam-test-suite branch from 5deca0f to c1ba0fa Compare November 6, 2024 19:26
Base automatically changed from chore/add-pam-test-suite to master November 6, 2024 20:57
@gitmp01 gitmp01 changed the base branch from master to chore/add-pam-test-suite November 6, 2024 20:59
@gitmp01 gitmp01 force-pushed the fix/eos-onchain-event-parsing branch from 7c0a8c4 to b47f775 Compare November 6, 2024 21:09
@gitmp01 gitmp01 changed the base branch from chore/add-pam-test-suite to master November 6, 2024 21:09
@gitmp01 gitmp01 merged commit 5999374 into master Nov 6, 2024
1 check passed
@gitmp01 gitmp01 deleted the fix/eos-onchain-event-parsing branch November 6, 2024 21:11
Copy link
Contributor

@envin3 envin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitmp01
Copy link
Collaborator Author

gitmp01 commented Nov 18, 2024

Better late than never 😅, sorry for not letting you know, I'll ping you privately next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check underlying precision of both tokens when registering them on the adapter contract
2 participants