Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pam specific tests (2/4) #48

Merged
merged 25 commits into from
Nov 6, 2024
Merged

Add pam specific tests (2/4) #48

merged 25 commits into from
Nov 6, 2024

Conversation

gitmp01
Copy link
Collaborator

@gitmp01 gitmp01 commented Oct 30, 2024 •
edited
Loading

Relevant changes

  • Operation's amount has been changed to asset for better usability
  • Removed setemitter & settopiczero
  • Restored pam.test.hpp for testing
  • Revised test utils.js
  • Event id should be used as an output parameter for check_authorization()

@gitmp01 gitmp01 force-pushed the chore/add-pam-test-suite branch from f02bf1c to 950ee44 Compare October 30, 2024 11:24
@gitmp01 gitmp01 changed the base branch from master to chore/rm-ts-from-event-attestator October 31, 2024 10:35
@gitmp01 gitmp01 force-pushed the chore/add-pam-test-suite branch from 950ee44 to ee94349 Compare October 31, 2024 10:56
Base automatically changed from chore/rm-ts-from-event-attestator to master October 31, 2024 17:54
@gitmp01 gitmp01 force-pushed the chore/add-pam-test-suite branch 6 times, most recently from a4dad8e to 5deca0f Compare November 4, 2024 08:20
gitmp01
gitmp01 commented Nov 4, 2024
View reviewed changes
cpp/contracts/adapter.cpp Show resolved Hide resolved
cpp/test/adapter-local.test.js Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this diff, but I have vscode auto-formatting enabled and is annoying

@gitmp01 gitmp01 requested a review from envin3 November 4, 2024 08:24
envin3
envin3 requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@envin3 envin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a merge with #51

@gitmp01 gitmp01 mentioned this pull request Nov 5, 2024
Merged
@gitmp01 gitmp01 changed the title Add pam specific tests Add pam specific tests (2/3) Nov 5, 2024
@gitmp01 gitmp01 changed the title Add pam specific tests (2/3) Add pam specific tests (2/4) Nov 6, 2024
@gitmp01 gitmp01 force-pushed the chore/add-pam-test-suite branch from 5deca0f to c1ba0fa Compare November 6, 2024 19:26
@gitmp01 gitmp01 merged commit e9ce187 into master Nov 6, 2024
1 check passed
@gitmp01 gitmp01 deleted the chore/add-pam-test-suite branch November 6, 2024 20:57
@gitmp01 gitmp01 restored the chore/add-pam-test-suite branch November 6, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envin3 envin3 envin3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitmp01 @envin3