Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors some part reported to a recent feedback #18

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Refactors some part reported to a recent feedback #18

merged 3 commits into from
Jul 29, 2024

Conversation

gitmp01
Copy link
Collaborator

@gitmp01 gitmp01 commented Jul 29, 2024

  • Commented metadata format updated
  • Typo: Unsufficient -> Insufficient
  • Include "not a contract" check into modifier
  • Include "only fees manager" check into modifier

@gitmp01 gitmp01 requested a review from ubordignon July 29, 2024 09:04
@gitmp01 gitmp01 merged commit c442ece into master Jul 29, 2024
1 check passed
@gitmp01 gitmp01 deleted the chore/required-changes branch July 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubordignon ubordignon Awaiting requested review from ubordignon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gitmp01