chore(solidity): add new linting rules

pnetwork-association · Jun 21, 2024 · c7eb07d · c7eb07d
1 parent 4c118c1
commit c7eb07d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/solidity/.solhint.json b/solidity/.solhint.json
@@ -1,3 +1,7 @@
 {
-  "extends": "solhint:default"
+  "extends": "solhint:default",
+  "rules": {
+    "ordering": "warn",
+    "private-vars-leading-underscore": ["warn", { "strict": false }]
+  }
 }
diff --git a/solidity/package.json b/solidity/package.json
@@ -10,7 +10,7 @@
   "scripts": {
     "build": "forge build",
     "test": "forge test",
-    "lint": "solhint src/**/*.sol",
+    "lint": "npx solhint src/**/*.sol",
     "prettier": "prettier --write ./src ./test",
     "coverage": "forge coverage --report summary"
   },

diff --git a/solidity/src/FeesManager.sol b/solidity/src/FeesManager.sol
@@ -16,7 +16,6 @@ contract FeesManager is IFeesManager, Ownable {
     bytes32 public WITHDRAW_ROLE;
     bytes32 public UPGRADE_ROLE;
     bytes32 public SET_FEE_ROLE;
-    bytes32 SLOT_DESTINATION_CHAIN_ID = keccak256("SLOT_DESTINATION_CHAIN_ID");
 
     struct Fee {
         uint256 minFee;