Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/migrate treasury funds #32

Open
wants to merge 5 commits into
base: feat/migration-wizard
Choose a base branch
from
Open

Feat/migrate treasury funds #32

wants to merge 5 commits into from

Conversation

envin3
Copy link
Contributor

@envin3 envin3 commented Feb 28, 2024

No description provided.

@envin3 envin3 changed the base branch from v1 to feat/changeInflationOwnerPreset February 28, 2024 20:09
@envin3 envin3 requested a review from oliviera9 February 28, 2024 20:09
oliviera9
oliviera9 suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preparer logic is not correct.

src/utils/presets/utils.js Show resolved Hide resolved
src/utils/presets/migrateTreasuryFunds.js Show resolved Hide resolved
Base automatically changed from feat/changeInflationOwnerPreset to v1 February 29, 2024 12:13
@envin3 envin3 force-pushed the feat/migrateTreasuryFunds branch from f15a935 to b707741 Compare March 6, 2024 10:28
@envin3 envin3 force-pushed the feat/migrateTreasuryFunds branch from b707741 to 98f25a7 Compare March 6, 2024 14:07
oliviera9
oliviera9 suggested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change required, then LGTM

@envin3 envin3 force-pushed the feat/migrateTreasuryFunds branch 3 times, most recently from b7f2ba9 to 3648d5b Compare March 8, 2024 13:06
oliviera9
oliviera9 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@envin3 envin3 changed the base branch from v1 to feat/migration-wizard March 15, 2024 08:57
@envin3 envin3 force-pushed the feat/migrateTreasuryFunds branch from 3648d5b to 256d015 Compare March 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviera9 oliviera9 oliviera9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envin3 @oliviera9