Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/v2/handle api partial data #15

Open
wants to merge 3 commits into
base: feat/multichain
Choose a base branch
from
Open

Refactor/v2/handle api partial data #15

wants to merge 3 commits into from

Conversation

envin3
Copy link
Contributor

@envin3 envin3 commented Oct 31, 2023

No description provided.

@envin3 envin3 requested a review from oliviera9 October 31, 2023 12:27
oliviera9
oliviera9 reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this PR the same as #14?

@envin3
Copy link
Contributor Author

envin3 commented Oct 31, 2023

Isn't this PR the same as #14?

This is for dao v2. The other one is for dao v1

@oliviera9
Copy link
Contributor

Isn't this PR the same as #14?

This is for dao v2. The other one is for dao v1

Got it. Clearly, the feat/multichain branch should be named v2

@envin3
Copy link
Contributor Author

envin3 commented Oct 31, 2023

Isn't this PR the same as #14?

This is for dao v2. The other one is for dao v1

Got it. Clearly, the feat/multichain branch should be named v2

#16
This PR will be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviera9 oliviera9 oliviera9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envin3 @oliviera9