Fix RewardsManager #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oghma
force-pushed
the
fix/rewards-manager
branch
from
ed974b8 to
3a0733d
Compare
…th non-voting users
oliviera9
force-pushed
the
fix/rewards-manager
branch
2 times, most recently
from
5b49598 to
24d0736
Compare
Oghma
force-pushed
the
fix/rewards-manager
branch
2 times, most recently
from
da02c7b to
a77cbee
Compare
…ple register/claims
oliviera9
force-pushed
the
fix/rewards-manager
branch
from
a77cbee to
95092b8
Compare
…erRewardsForEpoch()
…ager Refactor RewardsManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs:
registerRewardsForEpoch()multiple times with the same staker which did not vote in the target epoch would increaseunclaimableAmountByEpochindefinitelyregisterRewardsForEpoch()andclaimRewardByEpoch()repeatedly draining all funds.A new mapping
_stakerSeenByEpochwould track user registrations and avoid multiple registrations for the same epoch.