Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RewardsManager contract to manage DAO incentives for stakers #24

Merged
merged 15 commits into from
Feb 16, 2024

Conversation

oliviera9
Copy link

@oliviera9 oliviera9 commented Jan 29, 2024

  1. The new contract will receive tokens from whitelisted addresses, e.g. DAO voting contract.
  2. A permission-less function can be called by anyone to register for rewards for a specific epoch.
  3. One will be eligible for rewards if he has voted at least once in the specified epoch.
  4. Once a reward is registered for a user, the contract will mint daoPNT tokens for that user so they will account in his balance.
  5. Finally, the user will be able to withdraw his tokens after one year.

@oliviera9 oliviera9 force-pushed the feat/rewards-manager branch 2 times, most recently from bebcaca to d27f0ac Compare February 7, 2024 10:26
@gitmp01 gitmp01 self-requested a review February 12, 2024 08:53
Copy link

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues, few open question marks though.
Also, I didn't see integrations tests with the actual gnosis DandelioVotingContract, did you forget to push maybe?

contracts/core/RewardsManager.sol Outdated Show resolved Hide resolved
contracts/interfaces/IRewardsManager.sol Outdated Show resolved Hide resolved
test/RewardsManager.test.js Show resolved Hide resolved
test/RewardsManager.test.js Show resolved Hide resolved
test/RewardsManager.test.js Outdated Show resolved Hide resolved
contracts/core/RewardsManager.sol Show resolved Hide resolved
test/RewardsManager.test.js Show resolved Hide resolved
test/RewardsManager.test.js Outdated Show resolved Hide resolved
@oliviera9 oliviera9 force-pushed the feat/rewards-manager branch 3 times, most recently from 14270f7 to 93bc16f Compare February 14, 2024 12:26
@oliviera9 oliviera9 requested a review from gitmp01 February 14, 2024 12:31
Copy link

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/core/RewardsManager.sol Show resolved Hide resolved
test/constants.js Show resolved Hide resolved
contracts/core/LendingManager.sol Show resolved Hide resolved
test/LendingManager.test.js Show resolved Hide resolved
test/RewardsManager.test.js Show resolved Hide resolved
test/RewardsManager.test.js Outdated Show resolved Hide resolved
test/RewardsManager.test.js Show resolved Hide resolved
@oliviera9 oliviera9 force-pushed the feat/rewards-manager branch from 3f0afdf to 1a514ba Compare February 14, 2024 18:27
@oliviera9 oliviera9 force-pushed the feat/rewards-manager branch from 1a514ba to 52ce1fe Compare February 14, 2024 18:32
@oliviera9 oliviera9 merged commit 7b9dd64 into feat/v3 Feb 16, 2024
1 check passed
@oliviera9 oliviera9 deleted the feat/rewards-manager branch February 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants