test(rewards-manager): add unit test for registerRewardsForEpoch() wi…

…th non-voting users

test/RewardsManager.test.js

@@ -195,6 +195,11 @@ describe('RewardsManager', () => {
     await assertDaoPntBalances(['220000', '440000', '55000', '10000'])
     expect(await rewardsManager.unclaimableAmountByEpoch(0)).to.be.eq(ethers.parseUnits('1000'))
 
+    await expect(rewardsManager.connect(randomGuy).registerRewardsForEpoch(0, [pntHolder4.address])).to.not.be.reverted
+    await assertLockedRewardForEpoch(0, ['20000', '40000', '5000', '0'])
+    await assertDaoPntBalances(['220000', '440000', '55000', '10000'])
+    expect(await rewardsManager.unclaimableAmountByEpoch(0)).to.be.eq(ethers.parseUnits('1000'))
+
     await expect(rewardsManager.connect(pntHolder1).claimRewardByEpoch(0)).to.be.revertedWithCustomError(
       rewardsManager,
       'TooEarly'
@@ -237,6 +242,32 @@ describe('RewardsManager', () => {
     )
   })
 
+  it('should not count twice unclaimableRewards when registering the same user', async () => {
+    const amount = (ethers.parseUnits('660000') * 10n) / 100n
+    await setPermission(owner.address, tokenManager.target, MINT_ROLE)
+
+    await assertDaoPntBalances(['0', '0', '0', '0'])
+    // mint daoPNT to simulate staking
+    await mintDaoPnt(['200000', '400000', '50000', '10000'])
+    await assertDaoPntBalances(['200000', '400000', '50000', '10000'])
+    await assertPntBalances(['400000', '400000', '400000', '400000'])
+
+    expect(await epochsManager.currentEpoch()).to.be.eq(0)
+    await depositRewardsForEpoch(amount, 0)
+
+    await time.increase(ONE_DAY)
+    await dandelionVoting.newVote()
+    await setStakersVoteState(1, [VOTE_STATUS.YES, VOTE_STATUS.YES, VOTE_STATUS.ABSENT, VOTE_STATUS.ABSENT])
+    await time.increase(ONE_MONTH + ONE_DAY)
+    await expect(rewardsManager.connect(randomGuy).registerRewardsForEpoch(0, [pntHolder4.address])).to.not.be.reverted
+    expect(await rewardsManager.unclaimableAmountByEpoch(0)).to.be.eq(ethers.parseUnits('1000'))
+    // try to register again the same non-voting user
+    await expect(rewardsManager.connect(randomGuy).registerRewardsForEpoch(0, [pntHolder4.address])).to.not.be.reverted
+    expect(await rewardsManager.unclaimableAmountByEpoch(0)).to.be.eq(ethers.parseUnits('1000'))
+    await assertLockedRewardForEpoch(0, ['0', '0', '0', '0'])
+    await assertDaoPntBalances(['200000', '400000', '50000', '10000'])
+  })
+
   it('should not register anything if there is no vote in the epoch', async () => {
     const amount = (ethers.parseUnits('660000') * 10n) / 100n
     await setPermission(owner.address, tokenManager.target, MINT_ROLE)