Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #1, Accepting more arguments #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ckcksum
Copy link

@ckcksum ckcksum commented Dec 11, 2024

Current Behavior

  • terminal only accepts arguments for year and month.

New Behavior

  • Accepts more arguments in the order: year, month, sun, iso, only, lang.

Changes:

Constants Added: START_FROM_SUN, WITH_ISOWEEK, ONLY_THIS_MONTH, and LANG :

  • START_FROM_SUN : True if the week starts on Sunday.
    • Accepted values:
      • ["true", "t", "1", "sun", "sunday", "s", "yes", "y"]
      • ["false", "f", "0", "mon", "monday", "m", "no", "n"]
  • WITH_ISOWEEK: True to display week number
    • Accepted values: ["true", "t", "1", "yes", "y"] and ["false", "f", "0", "no", "n"]
  • ONLY_THIS_MONTH: Leaves days of other months as empty space without printing them.
    • Accepted values: ["true", "t", "1", "yes", "y"] and ["false", "f", "0", "no", "n"]
  • LANG
    • Accepted values:
      • ["en", "english", "eng", "e"] for English
      • ["ja", "japanese", "jp", "j"] for Japanese
      • ["cht", "chinese", "cn", "c", "zh", "ch"] for Chinese.

image
image

@ckcksum ckcksum marked this pull request as draft December 12, 2024 14:12
@ckcksum ckcksum marked this pull request as ready for review December 12, 2024 14:12
@ckcksum ckcksum marked this pull request as draft December 27, 2024 23:26
@ckcksum ckcksum marked this pull request as ready for review December 27, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant