Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2.x] final prep for 4.2.3rc1 #7149

Merged
merged 3 commits into from
Sep 24, 2024
Merged

[4.2.x] final prep for 4.2.3rc1 #7149

merged 3 commits into from
Sep 24, 2024

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Sep 24, 2024

Pull Request Description

Include #7144 and #7146 and update version info for 4.2.3 release candidate.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

hzhou and others added 3 commits September 23, 2024 10:01
Without LDFLAGS, LIBS such as -lcuda may miss -L path and result in
later mpich configure failures.
Fix compiler warning.
@raffenet
Copy link
Contributor Author

test:mpich/ch4/most
test:mpich/ch3/most

@raffenet raffenet requested a review from hzhou September 24, 2024 17:43
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raffenet raffenet merged commit ead3768 into pmodels:4.2.x Sep 24, 2024
7 of 8 checks passed
@raffenet raffenet deleted the 4.2.3rc1 branch September 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants