Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextjs guide #2328

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Update nextjs guide #2328

merged 8 commits into from
Feb 16, 2024

Conversation

dbritto-dev
Copy link
Collaborator

@dbritto-dev dbritto-dev commented Feb 13, 2024

Related Issues or Discussions

Improve nextjs guide -> repo: https://github.com/dbritto-dev/zustand-next-demo

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 2:22am

Copy link

codesandbox-ci bot commented Feb 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbritto-dev
Copy link
Collaborator Author

@Zafkiel45
Copy link

@dbritto-dev great! I'll be checking it out right now. Thanks for your attention

@alexander-densley
Copy link
Contributor

This is awesome @dbritto-dev, thanks for doing this!

Copy link
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any language or stylistic issues, so I approve.
I don't have a huge experience with modern Next.js, so I couldn't check the correctness of the code.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd review.

docs/guides/nextjs.md Outdated Show resolved Hide resolved
docs/guides/nextjs.md Outdated Show resolved Hide resolved
docs/guides/nextjs.md Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid suggesting zustand/traditional which isn't required.

@dbritto-dev
Copy link
Collaborator Author

@dai-shi that's updated

docs/guides/nextjs.md Outdated Show resolved Hide resolved
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

After the review, I notice the identity selector can be rather confusing. I'm okay to revert it to your original version.

@dai-shi dai-shi merged commit 8c1a1f0 into pmndrs:main Feb 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants