Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): errors and types fix for URL state example #2218

Merged
merged 5 commits into from
Dec 31, 2023
Merged

fix(docs): errors and types fix for URL state example #2218

merged 5 commits into from
Dec 31, 2023

Commits on Nov 28, 2023

  1. Update connect-to-state-with-url-hash.md 

    Resolved a few errors and type errors in the persist and create state with URL example:

1. createJsonStorage not being called in storageOptions resulting in a type error.
2. Correct hook not being exported
3. Moved the creation of initial state inline to get the correct types passed from create/persist.
4. Used state type as generic for persist.
    @CodyCodes95
    CodyCodes95 authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f5fea68 View commit details
    Browse the repository at this point in the history

  2. yarn prettier run

    @CodyCodes95
    CodyCodes95 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4336874 View commit details
    Browse the repository at this point in the history

  3. Update docs/guides/connect-to-state-with-url-hash.md 

    Better name for state in setter

Co-authored-by: Danilo Britto <[email protected]>
    @CodyCodes95 @dbritto-dev
    CodyCodes95 and dbritto-dev authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    599de84 View commit details
    Browse the repository at this point in the history

  4. prettier run

    @CodyCodes95
    CodyCodes95 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    caee831 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2023

  1. Merge branch 'main' into patch-1

    @dai-shi
    dai-shi authored Dec 31, 2023
    Configuration menu
    Copy the full SHA
    cf47d64 View commit details
    Browse the repository at this point in the history