feat: use webidl 'value.name' for emscripten setter parameter name

pmndrs · Oct 7, 2023 · f52d614 · f52d614
1 parent 24cc9e9
commit f52d614
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/khaki-mails-cheer.md b/.changeset/khaki-mails-cheer.md
@@ -0,0 +1,5 @@
+---
+"webidl-dts-gen": minor
+---
+
+feat: use webidl `value.name` for emscripten setter parameter name
diff --git a/packages/webidl-dts-gen/src/convert-idl.ts b/packages/webidl-dts-gen/src/convert-idl.ts
@@ -386,7 +386,7 @@ function createEmscriptenAttributeSetter(value: webidl2.AttributeMemberType) {
       ts.factory.createParameterDeclaration(
         [],
         undefined,
-        'value',
+        value.name,
         undefined,
         convertType(idlType),
       ),
@@ -397,7 +397,7 @@ function createEmscriptenAttributeSetter(value: webidl2.AttributeMemberType) {
       ts.factory.createParameterDeclaration(
         [],
         undefined,
-        'value',
+        value.name,
         undefined,
         convertType(idlType),
       ),

diff --git a/packages/webidl-dts-gen/tst/index.spec.ts b/packages/webidl-dts-gen/tst/index.spec.ts
@@ -208,7 +208,7 @@ describe('convert', () => {
         withDefaultEmscriptenOutput(
           'class Foo {', //
           '    get_position(): number;', //
-          '    set_position(value: number): void;', //
+          '    set_position(position: number): void;', //
           '    position: number;', //
           '}', //
         ),
@@ -228,7 +228,7 @@ describe('convert', () => {
         withDefaultEmscriptenOutput(
           'class Foo {', //
           '    get_position(index: number): number;', //
-          '    set_position(index: number, value: number): void;', //
+          '    set_position(index: number, position: number): void;', //
           '    position: number;', //
           '}', //
         ),